New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert replacing and deprecating constants with enums #6684

Closed

hugovk wants to merge 1 commit into python-pillow:main from hugovk:revert-constants-to-enums

Member

hugovk commented Oct 24, 2022

Fixes #6537

Changes proposed in this pull request:

Revert the changes in Added enums, deprecate constants #5954 (issue: Change from constants to enums #5875) as they will likely prove too disruptive for the limited benefits they bring
While enums are good for this sort of thing, and we should use them for new code, on balance let's keep this legacy code as simple integer constants


          Revert replacing and deprecating constants with enums

ff4ad1b

hugovk mentioned this pull request

API changes for Resampling modes #6537

Closed

radarhere mentioned this pull request

Change from constants to enums #5875

Closed

Member Author

hugovk commented Oct 25, 2022

Let's close this, I somehow had glossed over that the enums were already released in 9.1.0, so this itself would be a breaking change.

Some other ideas we're considering:

Keep the enums and deprecated ints
Keep the enums and deprecated ints, but extend deprecation period (e.g. from v10/July 2023 to v11/Oct 2024, or even without advertising an end date)
Provide API via both ints and enums, remove int deprecations

hugovk closed this

lanpa mentioned this pull request

fix PIL deprecation warning lanpa/tensorboardX#677

Merged

pmeier mentioned this pull request

Revert removal and deprecation of int values for interpolation? pytorch/vision#7205

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment