Restored __array__ for libraries that do not support __array_interface__ #6489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6422
The issue has discovered that tensorflow supports converting Pillow images using
__array__, but not__array_interface__. One solution would be to say that tensorflow should support__array_interface__, and an issue has been opened for that - tensorflow/tensorflow#56723This PR is an alternative, where we add
__array__, to provide support from our end. Conceivably, there may be other libraries that support__array__, but not__array_interface__. Testing, I find that NumPy prefers__array_interface__over__array__, so this should not affect NumPy use.