-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support reading BC4U and DX10 BC1 images #6486
Merged
Merged
Changes from 66 commits
Commits
Show all changes
68 commits
Select commit
Hold shift + click to select a range
f2d91fc
Add IntEnum/IntFlag for most of DDS members
REDxEYE de2b4be
Add Tile namedtuple for code readability.
REDxEYE 3f77a9e
Remove unused constants
REDxEYE 1988737
Add support for single channel textures
REDxEYE 3602e35
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 429dc28
Remove unnecessary tuple creation
REDxEYE 8e8a67e
Fix incorect file name
REDxEYE de8b89c
Add support for writing LA dds textures
REDxEYE a63fdc2
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 3476073
Add missing LA test textures
REDxEYE d1b1f30
Fix file extensions in tests not matching real names
REDxEYE 7c25e0b
Small refactor
REDxEYE 91664c9
Small refactor
REDxEYE 1c9a84d
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 9369a48
Revert, i didn't meant to commit it
REDxEYE 15c90ac
Simplified save code
REDxEYE b6b7a7b
Simplified test code
radarhere eda4192
Fixed typo
radarhere b87d4e0
Restored formatting
radarhere 9a7bd0d
Fixed big-endian bug
radarhere 78756cd
Simplified imports
radarhere cadac4a
Corrected error messages
radarhere bd48265
Removed INVALID enum
radarhere 9165771
Add BC5U support. Seen in Amnesia: The Bunker
REDxEYE 777c54a
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] a5dde8b
Apply suggestion for PR
REDxEYE 6dd565b
Merge remote-tracking branch 'pillow/main' into improved_dds
REDxEYE bc6c973
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] 2a6bcc1
Add missing annotation import
REDxEYE 69b922d
Replace self.mode with self._mode
REDxEYE 5e9a2e3
Renamed "tile_args" to "args" for consistency with existing ImageFile…
radarhere 51f7359
Loop over enums to create constants
radarhere f59c9ae
Merge pull request #4 from radarhere/improved_dds
REDxEYE 935958c
Removed unnecessary casting to enums
radarhere a54d28a
Merge branch 'main' into improved_dds
radarhere 4a4a1ee
Simplified tile creation
radarhere 8fbb610
Derive bit count from number of modes
radarhere 12e41e8
Simplified creating raw tiles
radarhere 93e0f39
Removed "mode-" prefix from image names that are not modes
radarhere 2ca9adb
Merge pull request #6 from radarhere/improved_dds
REDxEYE f58f410
ALPHA by itself does not mean bitcount is valid
radarhere 8548522
Support RGB bitcount 8
radarhere 0051fc9
Removed unnecessary seek
radarhere 17be898
Added tests for unimplemented bitcount
radarhere e3ff5eb
Test BC1_UNORM and BC1_TYPELESS
radarhere 4c635e4
Merge pull request #7 from radarhere/improved_dds
REDxEYE cb554c6
Update src/PIL/DdsImagePlugin.py
REDxEYE ee8c9c3
Removed unused test images
radarhere 5fd3035
Removed duplicate test
radarhere 8814610
Only unpack masks when necessary
radarhere ddcbfde
Test BC4U
radarhere 940224e
Remove wrong test_save input
REDxEYE c7fbfdc
Removed test_open
radarhere e0a726b
Merge pull request #8 from radarhere/improved_dds
REDxEYE 2f7caad
Merge pull request #9 from radarhere/test_open
REDxEYE 49578f0
Merge branch 'main' into improved_dds
radarhere 662cb22
Updated variable name to match tile
radarhere 56b4822
args may be a string or None
radarhere ab96324
Removed support for RGB bitcount 8
radarhere 5aadeb5
Moved _Tile to ImageFile
radarhere e072a12
Corrected constant values
radarhere 9e5ff76
Merge pull request #10 from radarhere/improved_dds
REDxEYE 2eddbc5
Updated docstrings
radarhere f2e478e
Merge branch 'main' into improved_dds
radarhere 66c5e9a
Added release notes
radarhere 9e6030f
Rename _420_OPAQUE to OPAQUE_420
REDxEYE 00c6a89
Link to plugin
radarhere d1a2235
Added tilde prefix
radarhere File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file renamed
BIN
+32.1 KB
Tests/images/unimplemented_pixel_format.dds → Tests/images/unimplemented_pfflags.dds
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
10.2.0 | ||
------ | ||
|
||
Backwards Incompatible Changes | ||
============================== | ||
|
||
TODO | ||
^^^^ | ||
|
||
TODO | ||
|
||
Deprecations | ||
============ | ||
|
||
TODO | ||
^^^^ | ||
|
||
TODO | ||
|
||
API Changes | ||
=========== | ||
|
||
TODO | ||
^^^^ | ||
|
||
TODO | ||
|
||
API Additions | ||
============= | ||
|
||
Added DdsImagePlugin enums | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
``DDSD``, ``DDSCAPS``, ``DDSCAPS2``, ``DDPF``, ``DXGI_FORMAT`` and ``D3DFMT`` | ||
enums have been added to DdsImagePlugin. | ||
radarhere marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
Security | ||
======== | ||
|
||
TODO | ||
^^^^ | ||
|
||
TODO | ||
|
||
Other Changes | ||
============= | ||
|
||
Added DDS BC4U and DX10 BC1 and BC4 reading | ||
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ||
|
||
Support has been added to read the BC4U format of DDS images. | ||
|
||
Support has also been added to read DX10 BC1 and BC4, whether UNORM or | ||
TYPELESS. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.