Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release updates #6172

Merged
merged 3 commits into from Apr 2, 2022
Merged

Release updates #6172

merged 3 commits into from Apr 2, 2022

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 1, 2022

Some things noticed during #6110.

Fix

$ # Nope
$ python3 -m check-manifest
/Library/Frameworks/Python.framework/Versions/3.10/bin/python3: No module named check-manifest
$ # Yep
$ check-manifest
$

Improvement

And as an opposite, we can call twine via python3 -m twine, and for twine check include --strict:

  --strict    Fail on warnings

radarhere
radarhere reviewed Apr 2, 2022
View reviewed changes
RELEASING.md Outdated Show resolved Hide resolved
radarhere
radarhere reviewed Apr 2, 2022
View reviewed changes
Makefile Outdated Show resolved Hide resolved
hugovk
hugovk commented Apr 2, 2022
View reviewed changes
Copy link
Member Author

@hugovk hugovk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@hugovk @radarhere
Fix commands
c3686c2 
Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@radarhere radarhere merged commit cf8be49 into python-pillow:main Apr 2, 2022
@hugovk hugovk deleted the update-release-things branch April 3, 2022 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hugovk @radarhere