Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added WebP default duration of zero when saving #6140

Merged
merged 1 commit into from Mar 22, 2022
Merged

Added WebP default duration of zero when saving #6140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 14 additions & 2 deletions Tests/test_file_webp.py
View file
Open in desktop
Expand Up @@ -8,6 +8,7 @@
from PIL import Image, WebPImagePlugin, features

from .helper import (
assert_image_equal,
assert_image_similar,
assert_image_similar_tofile,
hopper,
Expand Down Expand Up @@ -105,6 +106,19 @@ def test_write_method(self, tmp_path):
hopper().save(buffer_method, format="WEBP", method=6)
assert buffer_no_args.getbuffer() != buffer_method.getbuffer()

@skip_unless_feature("webp_anim")
def test_save_all(self, tmp_path):
temp_file = str(tmp_path / "temp.webp")
im = Image.new("RGB", (1, 1))
im2 = Image.new("RGB", (1, 1), "#f00")
im.save(temp_file, save_all=True, append_images=[im2])

with Image.open(temp_file) as reloaded:
assert_image_equal(im, reloaded)

reloaded.seek(1)
assert_image_similar(im2, reloaded, 1)

def test_icc_profile(self, tmp_path):
self._roundtrip(tmp_path, self.rgb_mode, 12.5, {"icc_profile": None})
if _webp.HAVE_WEBPANIM:
Expand Down Expand Up @@ -171,7 +185,6 @@ def test_file_pointer_could_be_reused(self):
Image.open(blob).load()
Image.open(blob).load()

@skip_unless_feature("webp")
@skip_unless_feature("webp_anim")
def test_background_from_gif(self, tmp_path):
with Image.open("Tests/images/chi.gif") as im:
Expand All @@ -191,7 +204,6 @@ def test_background_from_gif(self, tmp_path):
difference = sum(abs(original_value[i] - reread_value[i]) for i in range(0, 3))
assert difference < 5

@skip_unless_feature("webp")
@skip_unless_feature("webp_anim")
def test_duration(self, tmp_path):
with Image.open("Tests/images/dispose_bgnd.gif") as im:
Expand Down
2 changes: 1 addition & 1 deletion src/PIL/WebPImagePlugin.py
View file
Open in desktop
Expand Up @@ -192,7 +192,7 @@ def _save_all(im, fp, filename):
r, g, b = palette[background * 3 : (background + 1) * 3]
background = (r, g, b, 0)

duration = im.encoderinfo.get("duration", im.info.get("duration"))
duration = im.encoderinfo.get("duration", im.info.get("duration", 0))
loop = im.encoderinfo.get("loop", 0)
minimize_size = im.encoderinfo.get("minimize_size", False)
kmin = im.encoderinfo.get("kmin", None)
Expand Down