Fixed reading 9 to 15-bit PGM #6107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
changed the title
|
As requested, I've also now added 9, 12 and 14-bit. |
radarhere
changed the title
|
I feel a little bad for the prime numbered bits 11, 13, which have been sadly neglected, here and in the wild. |
|
Closing this PR, in favour of #6119, as it doesn't just resolve PPM reading for different bit depths, but other |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5403
The image from the issue is 10-bit PGM. As per http://netpbm.sourceforge.net/doc/pgm.html, this bit depth can be determined from the "maximum gray value (Maxval)" in the header (
sor# maxgreyin PpmImagePlugin) of 1023 (2 ** 10 - 1).This PR adds an unpacker for that. The test image included was created with ImageMagick using
convert hopper.png -depth 10 10_bit_binary.pgm.