Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various _accept changes #6092

Merged
merged 7 commits into from Mar 5, 2022
Merged

Various _accept changes #6092

merged 7 commits into from Mar 5, 2022

Commits on Feb 27, 2022

  1. Do not read data until necessary

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    fbaaf3c View commit details
    Browse the repository at this point in the history

  2. Raise SyntaxError if data is not as expected

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    efb9d50 View commit details
    Browse the repository at this point in the history

  3. Moved flags check into _accept

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    83b9e66 View commit details
    Browse the repository at this point in the history

  4. Make code clearer by matching _accept condition

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    885e305 View commit details
    Browse the repository at this point in the history

  5. Use _accept check in _open

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    e228835 View commit details
    Browse the repository at this point in the history

  6. Simplify code by using _accept

    @radarhere
    radarhere committed Feb 27, 2022
    Copy the full SHA
    56324c3 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2022

  1. Updated error message 

    Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
    @radarhere @hugovk
    radarhere and hugovk committed Mar 5, 2022
    Copy the full SHA
    633abcb View commit details
    Browse the repository at this point in the history