Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated show_file "file" argument in favour of "path" #5959

Merged
merged 2 commits into from Jan 16, 2022

Conversation

radarhere
Copy link
Member

First pointed out in #3450 (comment),

def show_file(self, file, **options):
the file argument mirrors the builtin file.

This PR deprecates it in favour of path.

@radarhere radarhere added the Deprecation Feature that will be removed in the future label Jan 15, 2022
@hugovk
Copy link
Member

hugovk commented Jan 15, 2022

@radarhere
Copy link
Member Author

Ok, done.

@hugovk hugovk merged commit 95c7083 into python-pillow:main Jan 16, 2022
@hugovk
Copy link
Member

hugovk commented Jan 16, 2022

Thanks!

@radarhere radarhere deleted the imageshow_file branch January 16, 2022 20:34
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
radarhere added a commit to radarhere/Pillow that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Deprecation Feature that will be removed in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants