Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace 'setup.py sdist' with '-m build --sdist' #5785

Merged
merged 1 commit into from Oct 26, 2021
Merged

Replace 'setup.py sdist' with '-m build --sdist' #5785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion Makefile
View file
Open in desktop
Expand Up @@ -96,7 +96,8 @@ release-test:

.PHONY: sdist
sdist:
python3 setup.py sdist --format=gztar
python3 -m build --help > /dev/null 2>&1 || python3 -m pip install build
python3 -m build --sdist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://docs.python.org/3/distutils/sourcedist.html

The default format is a gzip’ed tar file (.tar.gz) on Unix, and ZIP file on Windows.

So I think by removing the format argument, you're changing the Windows behaviour. I'm guessing that wasn't your intention though, and you just thought it wasn't necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build doesn't have a --format option and defaults to .tar.gz for all platforms:

Because PEP 517 only supports .tar.gz:

Which suits us fine.


.PHONY: test
test:
Expand Down