TGA color map entry size is only 1 byte #5396
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the TGA format, color map entry size is 1 byte.
It is currently read as 2 bytes though -
Pillow/src/PIL/TgaImagePlugin.py
Line 113 in b01fd46
This PR updates it to 1 byte rather than 2 - and as per #4614, it is written as
s[7]
rather thani8(s, 7)
.The reason that this hasn't been noticed is because the next byte is the 'X-origin', and I presume this is usually zero. As a test case, I've copied one of the existing test images and hexedited it so this isn't the case.
Credit to https://stackoverflow.com/a/63156250/4093019 for pointing this out, linked to from #4830