Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved efficiency when creating GIF disposal images #5326

Merged
merged 2 commits into from Mar 20, 2021
Merged

Improved efficiency when creating GIF disposal images #5326

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
16dbffc
_crop already makes a copy of the image
radarhere Mar 14, 2021
2f84f63
Create disposal image at the destination size, instead of cropping
radarhere Mar 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 11 additions & 7 deletions src/PIL/GifImagePlugin.py
View file
Open in desktop
Expand Up @@ -265,16 +265,20 @@ def _seek(self, frame):
self.dispose = None
elif self.disposal_method == 2:
# replace with background colour
Image._decompression_bomb_check(self.size)
self.dispose = Image.core.fill("P", self.size, self.info["background"])

# only dispose the extent in this frame
x0, y0, x1, y1 = self.dispose_extent
dispose_size = (x1 - x0, y1 - y0)

Image._decompression_bomb_check(dispose_size)
self.dispose = Image.core.fill(
"P", dispose_size, self.info["background"]
)
else:
# replace with previous contents
if self.im:
self.dispose = self.im.copy()

# only dispose the extent in this frame
if self.dispose:
self.dispose = self._crop(self.dispose, self.dispose_extent)
# only dispose the extent in this frame
self.dispose = self._crop(self.im, self.dispose_extent)
except (AttributeError, KeyError):
pass

Expand Down