Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed Image.open formats parameter to be case-insensitive #5250

Merged
merged 4 commits into from Feb 8, 2021
Merged

Changed Image.open formats parameter to be case-insensitive #5250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0c1675a
Make `formats` parameter in `Image.open` accept aNy cAsE
Piolie Feb 5, 2021
587e073
Moved case transformation before initialization check
radarhere Feb 5, 2021
4a9a999
Update Tests/test_image.py
Piolie Feb 5, 2021
957cc1b
Merge pull request #2 from radarhere/open_formats_case
Piolie Feb 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tests/test_image.py
View file
Open in desktop
Expand Up @@ -94,7 +94,7 @@ def test_open_formats(self):
with pytest.raises(TypeError):
Image.open(PNGFILE, formats=123)

for formats in [["JPEG"], ("JPEG",)]:
for formats in [["JPEG"], ("JPEG",), ["jpeg"], ["Jpeg"], ["jPeG"], ["JpEg"]]:
with pytest.raises(UnidentifiedImageError):
Image.open(PNGFILE, formats=formats)

Expand Down
1 change: 1 addition & 0 deletions src/PIL/Image.py
View file
Open in desktop
Expand Up @@ -2922,6 +2922,7 @@ def open(fp, mode="r", formats=None):

def _open_core(fp, filename, prefix, formats):
for i in formats:
i = i.upper()
if i not in OPEN:
init()
try:
Expand Down