Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved handling of PPM header #5121

Merged
merged 23 commits into from Mar 4, 2022
Merged

Improved handling of PPM header #5121

merged 23 commits into from Mar 4, 2022

Commits on Dec 22, 2020

  1. Improve handling of PPM headers

    @Piolie
    Piolie committed Dec 22, 2020
    Copy the full SHA
    6b81e34 View commit details
    Browse the repository at this point in the history

  2. Improve PPM tests

    @Piolie
    Piolie committed Dec 22, 2020
    Copy the full SHA
    699afe1 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2021

  1. Correctly check magic number

    @Piolie
    Piolie committed Jan 5, 2021
    Copy the full SHA
    d2ad27d View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2021

  1. Add token limit

    @Piolie
    Piolie committed Jan 6, 2021
    Copy the full SHA
    4dbe244 View commit details
    Browse the repository at this point in the history

  2. Revert exception types to ValueError

    @Piolie
    Piolie committed Jan 6, 2021
    Copy the full SHA
    5d0ad5e View commit details
    Browse the repository at this point in the history

  3. Add tests for token size and wrong magic number

    @Piolie
    Piolie committed Jan 6, 2021
    Copy the full SHA
    002e0bd View commit details
    Browse the repository at this point in the history

  4. Suppress exception context

    @Piolie
    Piolie committed Jan 6, 2021
    Copy the full SHA
    73fed77 View commit details
    Browse the repository at this point in the history

  5. Make minor changes to tests 

    - add test for maxcolors;
- extend coverage for wrong magic number;
- fix linting.
    @Piolie
    Piolie committed Jan 6, 2021
    Copy the full SHA
    bc5ecfb View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2021

  1. Change max token size to 10 

    - ...so as not to reject "2,147,483,647" (2 ** 31 - 1);
- reword exception message.
    @Piolie
    Piolie committed Jan 31, 2021
    Copy the full SHA
    50522d9 View commit details
    Browse the repository at this point in the history

  2. Create maxval variable

    @Piolie
    Piolie committed Jan 31, 2021
    Copy the full SHA
    39288f0 View commit details
    Browse the repository at this point in the history

  3. Change variable name in _read_magic()

    @Piolie
    Piolie committed Jan 31, 2021
    Copy the full SHA
    b43654d View commit details
    Browse the repository at this point in the history

  4. Rewrite _ignore_comment as one-liner

    @Piolie
    Piolie committed Jan 31, 2021
    Copy the full SHA
    b6f6fba View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2021

  1. Added context managers

    @radarhere
    radarhere committed Mar 21, 2021
    Copy the full SHA
    41a439d View commit details
    Browse the repository at this point in the history

  2. Fix wrong extension in temp test files

    @Piolie
    Piolie committed Mar 21, 2021
    Copy the full SHA
    8ad5172 View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2021

  1. Keep case consistency in error messages 

    Co-authored-by: Andrew Murray <3112309+radarhere@users.noreply.github.com>
    @Piolie @radarhere
    Piolie and radarhere committed Mar 22, 2021
    Copy the full SHA
    9c2cbcf View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2022

  1. Reverted SyntaxError change to match other plugins

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    e2e87d7 View commit details
    Browse the repository at this point in the history

  2. Retain variable case for backwards compatibility

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    cb4e267 View commit details
    Browse the repository at this point in the history

  3. Removed re-raising of exception

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    3426052 View commit details
    Browse the repository at this point in the history

  4. Explicitly check if magic number is empty

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    f5b9e2c View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into PPMheaders

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    65edcc4 View commit details
    Browse the repository at this point in the history

  6. Updated tests

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    d968301 View commit details
    Browse the repository at this point in the history

  7. Refactored to reduce risk of infinite loop

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    4f8173f View commit details
    Browse the repository at this point in the history

  8. Changed variable

    @radarhere
    radarhere committed Mar 4, 2022
    Copy the full SHA
    f7504b1 View commit details
    Browse the repository at this point in the history