Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove excess Travis CI jobs #5029

Merged
merged 6 commits into from
Nov 18, 2020
Merged

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Nov 3, 2020

For #5028.

Changes proposed in this pull request:

  • Remove jobs which are already run on GitHub Actions

TODO

  • Check coverage drops and see what's tested on Travis that's not in GHA

    • Ideally add to GHA
    • Or keep a single Travis job for a bit longer
    • Or take the drop
  • There's some redundant bits of scripts that can be removed now or later, e.g. TRAVIS_PYTHON_VERSION checks

@nulano
Copy link
Contributor

nulano commented Nov 3, 2020

I can see two changes on Codecov:

  • XCB is not available in any GHA jobs (some Docker jobs have XCB but report an unsupported bit depth)
  • the PYTHONOPTIMIZE=2 setting is not working on GHA, as seen by the coverage change in test_image_access.py on line 17

An unrelated change is in test_image_quantize which is caused by the Windows jobs (imagequant is enabled for PRs but not for pushes, which means the skip code is not hit for PRs)

@hugovk
Copy link
Member Author

hugovk commented Nov 3, 2020

  • the PYTHONOPTIMIZE=2 setting is not working on GHA, as seen by the coverage change in test_image_access.py on line 17

Thanks, fixed setting the PYTHONOPTIMIZE env vars in b01567f (#5029).

@hugovk
Copy link
Member Author

hugovk commented Nov 4, 2020

PyQt now added to GHA, like Travis had, so some skipped PyQt tests are now ran:

SKIPPED [1] Tests/test_image_fromqimage.py:38: Qt bindings are not installed
SKIPPED [1] Tests/test_image_fromqimage.py:43: Qt bindings are not installed
SKIPPED [1] Tests/test_image_fromqimage.py:48: Qt bindings are not installed
SKIPPED [1] Tests/test_image_fromqimage.py:53: Qt bindings are not installed
SKIPPED [1] Tests/test_image_fromqimage.py:58: Qt bindings are not installed
...
SKIPPED [1] Tests/test_imageqt.py:32: Qt bindings are not installed
SKIPPED [1] Tests/test_imageqt.py:58: Qt bindings are not installed
SKIPPED [4] Tests/test_imagetk.py:30: TCL Error: no display name and no $DISPLAY environment variable
...
SKIPPED [1] Tests/test_qt_image_fromqpixmap.py:13: Qt bindings are not installed
SKIPPED [1] Tests/test_qt_image_toqimage.py:22: Qt bindings are not installed
SKIPPED [1] Tests/test_qt_image_toqimage.py:54: Qt bindings are not installed
SKIPPED [1] Tests/test_qt_image_toqpixmap.py:11: Qt bindings are not installed

I didn't find a way to add XCB, although adding Qt changed this skip:

SKIPPED [1] Tests/test_imagegrab.py:37: X connection failed: error 5

into:

SKIPPED [1] Tests/test_imagegrab.py:37: unsupported bit depth: 16

The coverage drops in this PR compared to master:

src/display.c

XCB stuff:

image

Tests/test_imagegrab.py

image

XCB stuff, this is:

SKIPPED [1] Tests/test_imagegrab.py:37: unsupported bit depth: 16

Tests/test_image_quantize.py

If I'm interpreting correctly, we're not skipping this test, so coverage dropped! Will add a pragma: no cover to the except block:

image

https://codecov.io/gh/python-pillow/Pillow/src/8ec8d23af47e4f718d1b3a0c1f3cbf645c1be649/Tests/test_image_quantize.py

Edit: done.

@hugovk hugovk marked this pull request as ready for review November 4, 2020 14:23
@hugovk
Copy link
Member Author

hugovk commented Nov 4, 2020

I'd like to get this merged soon so we can right away start conserving Travis credits. I've already used a third of my allowance in two days!

I'm not sure how to get the XCB stuff into GHA (or AppVeyor). Do we want to:

  • Take the miss, maybe figure it out later?
  • Add a single vanilla Python back in Travis, maybe figure it out later?

@nulano
Copy link
Contributor

nulano commented Nov 4, 2020

I've just created hugovk#62 to resolve the XCB coverage.

@hugovk
Copy link
Member Author

hugovk commented Nov 4, 2020

Great timing, thank you!

@hugovk hugovk mentioned this pull request Nov 16, 2020
5 tasks
@hugovk hugovk merged commit 626051f into python-pillow:master Nov 18, 2020
@hugovk hugovk deleted the less-travis branch November 18, 2020 08:21
@hugovk hugovk added the Testing label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants