Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Replace test images from pillow-depends #5001

Merged
merged 1 commit into from Oct 23, 2020

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Oct 22, 2020

For #4764 (comment):

GHA Window CI failed with "Overwrite D:\a\Pillow\Pillow\Tests\images\string_dimension.tiff (Yes/No/All)?", will be because of #4993 / python-pillow/pillow-depends#34, so will include that too: f886bc9.

Do not prompt to overwrite when copying test images from pillow-depends on Windows CIs so the above will not be needed for future point releases or when working on an old branch.

Successful test from my repo (does not include #4993): https://github.com/nulano/Pillow/runs/1293222859?check_suite_focus=true#step:10:32

@hugovk
Copy link
Member

hugovk commented Oct 22, 2020

Thanks for the PR! I'm going to cancel the Travis build for now to clear the way for the release, because Travis is again giving us less than 5 jobs, it's been 2 and is actually zero right now... We'll restart it after the release is out!

@nulano
Copy link
Contributor Author

nulano commented Oct 22, 2020

Thanks for the PR! I'm going to cancel the Travis build for now to clear the way for the release, because Travis is again giving us less than 5 jobs, it's been 2 and is actually zero right now... We'll restart it after the release is out!

I think Travis should give preference to the earlier build, but it can't hurt to run this later 👍 .

https://www.traviscistatus.com#week shows less than 600 running jobs with over 4000 in the queue...

@hugovk
Copy link
Member

hugovk commented Oct 22, 2020

Yeah, as soon as that first one ends the version bump will be pushed as a branch and tag build (will have to cancel those), and then the big wheels build...

I'm actually also running the first one on my fork https://travis-ci.com/github/hugovk/Pillow/builds/191711135 and once that passes, I'll cancel the first one too.

I've already migrated my builds from https://travis-ci.org to https://travis-ci.com, and for some reason they give 7 parallel jobs there! We'll have to migrate the main builds at some point, but the full history is not yet being migrated: https://travis-ci.community/t/question-regarding-build-history-after-org-com-migration/7906?u=hugovk

@nulano
Copy link
Contributor Author

nulano commented Oct 22, 2020

I wonder if it would be worth migrating at least the x86 builds to GHA for 20 parallel jobs, and so far no backlog that I have seen. Looking at the multibuild scripts I do not see any obvious problems. I might give it a try later this week if I have time.

@hugovk
Copy link
Member

hugovk commented Oct 22, 2020

It's probably worth moving it all over, but any increment would help!

@hugovk hugovk merged commit 95d0134 into python-pillow:master Oct 23, 2020
@hugovk
Copy link
Member

hugovk commented Oct 23, 2020

Thanks!

@nulano nulano deleted the gha-replace branch October 23, 2020 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants