Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed ICNS file pointer saving #4741

Merged
merged 1 commit into from Jun 29, 2020
Merged

Fixed ICNS file pointer saving #4741

merged 1 commit into from Jun 29, 2020

Conversation

radarhere
Copy link
Member

Resolves #4732

The scenario from the issue is

fp = io.BytesIO()
im.save(fp, format="ICNS")

It fails for ICNS due the use of the iconutil command line tool, rather than the usual writing to fp. This resolves it by creating a temporary file.

@radarhere radarhere mentioned this pull request Jun 28, 2020
Closed
@radarhere radarhere added the Bug Any unexpected behavior, until confirmed feature. label Jun 28, 2020
@hugovk hugovk merged commit 74a4c88 into python-pillow:master Jun 29, 2020
@radarhere radarhere deleted the icns branch June 29, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Any unexpected behavior, until confirmed feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CalledProcessError saving icns file to io.BytesIO()
2 participants
@radarhere @hugovk