Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace IOError and WindowsError aliases with OSError #4536

Merged
merged 4 commits into from Apr 10, 2020
Merged

Replace IOError and WindowsError aliases with OSError #4536

merged 4 commits into from Apr 10, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Apr 7, 2020

Fixes #4535.

Changes proposed in this pull request:

Two questions:

In src/PIL/ImageFile.py, this PR renames the raise_ioerror helper function to raise_oserror. Technically this could be considered a breaking change.

  1. Should we keep the old raise_ioerror with a deprecation warning?
  2. Should we name the new one _raise_oserror to indicate it is internal?

@hugovk hugovk mentioned this pull request Apr 7, 2020
Closed
@radarhere radarhere mentioned this pull request Apr 7, 2020
Merged
@radarhere radarhere merged commit 3bb39c7 into python-pillow:master Apr 10, 2020
@hugovk hugovk deleted the oserror branch April 10, 2020 11:03
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 21, 2020
@radarhere
Added release notes for python-pillow#4536 [ci skip]
c76dfba
@radarhere radarhere mentioned this pull request Jun 21, 2020
Merged
@radarhere radarhere mentioned this pull request Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radarhere radarhere radarhere left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImageFont documentation does not match with current code
2 participants
@hugovk @radarhere