Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Codecov bash because the Action times out on macOS #4444

Merged
merged 1 commit into from Feb 24, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 22, 2020

Changes proposed in this pull request:

  • Use the Codecov bash uploader for macOS and Linux, because the Action was times out on macOS after 12 minutes
  • Fixes macOS coverage

Recently, the Codecov Action for uploading coverage has been timing out after about 12 minutes on macOS. Most recent master build:

2020-02-21T22:12:07.4228970Z �[0;90m==>�[0m Uploading reports
2020-02-21T22:12:07.4230580Z     �[0;90murl:�[0m https://codecov.io
2020-02-21T22:12:07.4231890Z     �[0;90mquery:�[0m branch=master&commit=20d6b6271ce329870e1fab7f6b750838eb56510e&build=&build_url=http%3A%2F%2Fgithub.com%2Fpython-pillow%2FPillow%2Factions%2Fruns%2F&name=macOS-latest%20Python%20pypy3&tag=&slug=python-pillow%2FPillow&service=github-actions&flags=GHA_macOS&pr=&job=
2020-02-21T22:12:07.4336250Z     �[0;90m->�[0m Pinging Codecov
2020-02-21T22:12:07.4337830Z https://codecov.io/upload/v4?package=bash-20200214-585fef0&token=secret&branch=master&commit=20d6b6271ce329870e1fab7f6b750838eb56510e&build=&build_url=http%3A%2F%2Fgithub.com%2Fpython-pillow%2FPillow%2Factions%2Fruns%2F&name=macOS-latest%20Python%20pypy3&tag=&slug=python-pillow%2FPillow&service=github-actions&flags=GHA_macOS&pr=&job=
2020-02-21T22:12:07.8370190Z     �[0;90m->�[0m Uploading
2020-02-21T22:13:07.9564500Z     �[0;31mX>�[0m Failed to upload
2020-02-21T22:13:07.9565190Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:13:38.0845530Z     �[0;90m->�[0m Pinging Codecov
2020-02-21T22:13:38.0846580Z https://codecov.io/upload/v4?package=bash-20200214-585fef0&token=secret&branch=master&commit=20d6b6271ce329870e1fab7f6b750838eb56510e&build=&build_url=http%3A%2F%2Fgithub.com%2Fpython-pillow%2FPillow%2Factions%2Fruns%2F&name=macOS-latest%20Python%20pypy3&tag=&slug=python-pillow%2FPillow&service=github-actions&flags=GHA_macOS&pr=&job=
2020-02-21T22:13:38.3309090Z     �[0;90m->�[0m Uploading
2020-02-21T22:14:38.4381230Z     �[0;31mX>�[0m Failed to upload
2020-02-21T22:14:38.4382970Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:15:08.5549940Z     �[0;90m->�[0m Pinging Codecov
2020-02-21T22:15:08.5550950Z https://codecov.io/upload/v4?package=bash-20200214-585fef0&token=secret&branch=master&commit=20d6b6271ce329870e1fab7f6b750838eb56510e&build=&build_url=http%3A%2F%2Fgithub.com%2Fpython-pillow%2FPillow%2Factions%2Fruns%2F&name=macOS-latest%20Python%20pypy3&tag=&slug=python-pillow%2FPillow&service=github-actions&flags=GHA_macOS&pr=&job=
2020-02-21T22:15:08.8578280Z     �[0;90m->�[0m Uploading
2020-02-21T22:16:08.9588660Z     �[0;31mX>�[0m Failed to upload
2020-02-21T22:16:08.9589900Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:16:39.0990190Z     �[0;90m->�[0m Pinging Codecov
2020-02-21T22:16:39.0991150Z https://codecov.io/upload/v4?package=bash-20200214-585fef0&token=secret&branch=master&commit=20d6b6271ce329870e1fab7f6b750838eb56510e&build=&build_url=http%3A%2F%2Fgithub.com%2Fpython-pillow%2FPillow%2Factions%2Fruns%2F&name=macOS-latest%20Python%20pypy3&tag=&slug=python-pillow%2FPillow&service=github-actions&flags=GHA_macOS&pr=&job=
2020-02-21T22:16:39.3449530Z     �[0;90m->�[0m Uploading
2020-02-21T22:17:39.4338130Z     �[0;31mX>�[0m Failed to upload
2020-02-21T22:17:39.4339250Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:18:09.5599610Z     �[0;90m->�[0m Uploading to Codecov
2020-02-21T22:19:09.6541500Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:20:39.8930390Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:22:10.0224740Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:23:40.2020460Z     �[0;90m->�[0m Sleeping for 30s and trying again...
2020-02-21T22:24:10.3447750Z     �[0;31mX> Failed to upload coverage reports�[0m

https://github.com/python-pillow/Pillow/runs/461238759?check_suite_focus=true

This may account for the "failing" +- check on PRs (eg. #4404):

image

Plus the lack of GHA_macOS flag on files:

image

https://codecov.io/gh/python-pillow/Pillow/src/a8c07941074a16ee06879071f42ea5b624210f5f/src/PIL/BdfFontFile.py


Switching to the Codecov bash uploader fixes it, uploads coverage in 7s:

image

And shows the flag:

image

https://codecov.io/gh/hugovk/Pillow/src/3218cf8afe4e7d102a62dcfd82d4562807cad274/src/PIL/BdfFontFile.py


I've not reported this to Codecov, and didn't find it in their issue tracker or on the forum, but they often suggest to people to try the bash uploader if they have problems with the Action or Python client, as the bash client is their main cross-platform tool with the most maintenance.

@hugovk hugovk added the Testing label Feb 22, 2020
@radarhere
Copy link
Member

The lack of coverage at https://codecov.io/gh/python-pillow/Pillow/src/3218cf8afe4e7d102a62dcfd82d4562807cad274/src/PIL/ImageGrab.py makes me concerned that something still isn't right?

@hugovk
Copy link
Member Author

hugovk commented Feb 23, 2020

Possibly due to " Reports are queued for processing... Please review report with caution, it may change"?

This commit on python-pillow/Pillow:

image

https://codecov.io/gh/python-pillow/Pillow/src/3218cf8afe4e7d102a62dcfd82d4562807cad274/src/PIL/ImageGrab.py

The same commit on my fork:

image

https://codecov.io/gh/hugovk/Pillow/src/3218cf8afe4e7d102a62dcfd82d4562807cad274/src/PIL/ImageGrab.py

There's been quite a bit of "Reports are queued for processing..." lately at Codecov, and some HTTP 500 errors.

Will rebase and see how the next build goes.

@hugovk
Copy link
Member Author

hugovk commented Feb 23, 2020

@python-pillow python-pillow deleted a comment from codecov bot Feb 24, 2020
@radarhere radarhere merged commit 80994bc into python-pillow:master Feb 24, 2020
@hugovk hugovk deleted the codecov-bash branch February 24, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants