Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pytest.importorskip to skip on a missing import dependency #4436

Merged
merged 4 commits into from
Feb 20, 2020

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 18, 2020

For #4193.

Changes proposed in this pull request:

@hugovk hugovk added the Testing label Feb 18, 2020
@hugovk hugovk added this to New Issues in Pillow via automation Feb 18, 2020
@radarhere
Copy link
Member

Just so you're aware, this is an alternative to #4434

@hugovk
Copy link
Member Author

hugovk commented Feb 18, 2020

This actually covers something different to #4434: that skips tests when features are not available, this skips tests when imports are not possible :)

@hugovk
Copy link
Member Author

hugovk commented Feb 19, 2020

Ah, there was a bit of overlap for a bit of the WebP checking. Will update this to keep those as feature checking.

@python-pillow python-pillow deleted a comment from codecov bot Feb 19, 2020
Co-Authored-By: Andrew Murray <3112309+radarhere@users.noreply.github.com>
@python-pillow python-pillow deleted a comment from codecov bot Feb 20, 2020
@radarhere radarhere merged commit f87505c into python-pillow:master Feb 20, 2020
@hugovk hugovk deleted the pytest.importorskip branch February 20, 2020 21:43
@radarhere radarhere moved this from New Issues to Done in Pillow Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Pillow
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants