Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline test skipping based on supported features #4434

Merged
merged 3 commits into from
Feb 19, 2020
Merged

Streamline test skipping based on supported features #4434

merged 3 commits into from
Feb 19, 2020

Commits on Feb 18, 2020

  1. Remove unnecessary skip test logic 

    The gif_encoder and gif_decoder are always compiled and included in
src/_imaging.c.
    @jdufresne
    jdufresne committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    967f46d View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary setup_module() from test_file_tar.py 

    The test_sanity() already checks the decorder exists and the other tests
can run without zlib/jpeg installed.
    @jdufresne
    jdufresne committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    f72e64b View commit details
    Browse the repository at this point in the history

  3. Streamline test skipping based on supported features 

    This adds a new test decorator: skip_unless_feature(). The argument is
the same as passed to features.check(). If the feature is not supported,
the test will be skipped.

This removes several kinds of boilerplate copied and pasted around tests
so test feature checking is handled and displayed more consistently.

Refs #4193
    @jdufresne
    jdufresne committed Feb 18, 2020
    Configuration menu
    Copy the full SHA
    4f18532 View commit details
    Browse the repository at this point in the history