Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change ContainerIO return type to match file object mode #4297

Merged
merged 3 commits into from Feb 15, 2020
Merged

Change ContainerIO return type to match file object mode #4297

merged 3 commits into from Feb 15, 2020

Commits on Feb 15, 2020

  1. Correct str/bytes mixup in ContainerIO 

    Image data is expected to be read in bytes mode, not text mode so
ContainerIO should return bytes in all methods. The passed in file
handler is expected to be opened in bytes mode (as TarIO already does).
    @jdufresne @radarhere
    jdufresne authored and radarhere committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    e817ed0 View commit details
    Browse the repository at this point in the history

  2. Return strings or bytes from ContainerIO according to the file object… 

    … mode
    @radarhere
    radarhere committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    f958e2f View commit details
    Browse the repository at this point in the history

  3. For effiency, set newline character outside of loop

    @radarhere
    radarhere committed Feb 15, 2020
    Configuration menu
    Copy the full SHA
    8acf77a View commit details
    Browse the repository at this point in the history