Enabled page heap verification #4186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very good! Do you know if this is possible with GitHub Actions? |
radarhere
changed the title
|
Okay, added it to GHA as well. |
|
I was just working on this a week ago, but I wanted to add crash dumps, and got sidetracked with a ton of other work. My WIP branch is here, if you would like to finish the dump part (it was exiting with the wrong exit code): https://github.com/nulano/Pillow/commits/heap |
|
Thanks both, let's merge this now and further improvements always welcome in the future! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in #3618 (comment)
Helps prevent #4152 (comment)
Used https://docs.microsoft.com/en-us/windows-hardware/drivers/debugger/example-12---using-page-heap-verification-to-find-a-bug
As a demonstration, this will fail until #4160 is merged.