Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PyPy3 on AppVeyor #4082

Merged
merged 5 commits into from Sep 24, 2019
Merged

PyPy3 on AppVeyor #4082

merged 5 commits into from Sep 24, 2019

Conversation

nulano
Copy link
Contributor

@nulano nulano commented Sep 23, 2019

Adds PyPy3 to AppVeyor.

From #3835 (comment):

Our tests didn't pick it up because we don't test PyPy3 on Windows; [...] We should improve these testing gaps.

Using a nightly build due to:

PyPy3 is set to run last because this is not a stable release.

(cherry picked from commit 593ea32)
(cherry picked from commit 1ffdfd4)
(cherry picked from commit a5ca54a)
(cherry picked from commit 2d2076f)
(cherry picked from commit d8c3dfd)
@hugovk
Copy link
Member

hugovk commented Sep 23, 2019

Thanks for this!

I'm cautious about using a nightly build, in case pre-release PyPy bugs fail the build. It'd be annoying for that to happen after an hour!

If certain tests are failing on a given PyPy3 version, we can add a conditional skipIf on is_pypy and that particular version, and then update when the next PyPy release is out.

@radarhere
Copy link
Member

Note that I've created PR #4083 as an alternative fix for https://bitbucket.org/pypy/pypy/issues/3079/systemerror-in-timestrptime-with-non

@nulano
Copy link
Contributor Author

nulano commented Sep 23, 2019

The first linked issue causes a crash in selftest.py: https://ci.appveyor.com/project/nulano/pillow/builds/27564402/job/j7ugyr3o4nxw0g77#L6455
I'm not sure if that can be skipped reasonably.

The second one is in test_pdfparser.py, which I did set to skip while the issue was being worked on in PyPy:
https://ci.appveyor.com/project/nulano/pillow/builds/27570685/job/3a9a5k889njigrkb#L8824

@nulano
Copy link
Contributor Author

nulano commented Sep 23, 2019

See https://bitbucket.org/pypy/pypy/issues/3037/pypy36-release-schedule-new-beta-quality

We don’t have a release schedule. We try to release twice a year, so I guess the time is getting close. The nightly builds should be quite reliable, is there a reason you cannot use them?

We don't have a release schedule. With that, we may be releasing a new version by the end of September

Perhaps this can wait for pypy-7.2.0?

@hugovk
Copy link
Member

hugovk commented Sep 23, 2019

Yeah, the end of September would be good timing, we're removing PyPy2 after the 1st October release. And let's check #4083.

@radarhere Any thoughts on using the nightly until the next release, or waiting until it the next PyPy release is out?

@radarhere
Copy link
Member

radarhere commented Sep 23, 2019

After some thought, I'm in favour of using the nightly until the next release. It seems to me that it's helpful for the same reason why we use a dev version of Python 3.8 - to ensure that there aren't bugs when we get to the actual release.

@nulano
Copy link
Contributor Author

nulano commented Sep 23, 2019

I'm cautious about using a nightly build, in case pre-release PyPy bugs fail the build. It'd be annoying for that to happen after an hour!

If you'd prefer, I can remove the last commit and put PyPy3 at the top, as I had it while working on this.

@hugovk
Copy link
Member

hugovk commented Sep 24, 2019

Let's leave it where it is. If it was first, it's not obvious if a failure is from your changes or nightly.

When the next official release is out, we can reconsider the position.

Thank you!

@hugovk hugovk merged commit e17f728 into python-pillow:master Sep 24, 2019
@nulano nulano deleted the winbuild-pypy3 branch September 24, 2019 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants