Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ImageOps auto_transpose #4062

Closed
wants to merge 1 commit into from

Conversation

radarhere
Copy link
Member

Resolves #4053

The issue points out in addition to the EXIF orientation tag, there is also a TIFF orientation tag - https://www.awaresystems.be/imaging/tiff/tifftags/orientation.html

Unfortunately, the auto transposing method for EXIF orientation was named exif_transpose, so I'm not able to just bundle the handling of the TIFF tag into that. So this PR adds auto_transpose to transpose either the EXIF or the TIFF orientation tag.

@ailintom
Copy link

I guess, correcting the orientation of TIFF images as per Orientation tag should not in any way be linked to processing the EXIF tag. TIFF Orientation is a much more technical thing, like byte order or compression and should be applied automatically to all TIFF images that have Orientation differing from 1. It is a baseline tag, and it is not up to the user to decide whether they want to read TIFF images in the correct orientation just like it is not up to the user to decide whether they want to decode LZW compressed TIFFs or leave them compressed. (But some applications like the current version of Pillow simply do not support orientations other than 1, like some applications do not support some compressions).

And whether to apply EXIF orientation is up to the user or the developer. This correction should be initiated by a separate procedure call. (Like it is already implemented in Pillow).

@radarhere radarhere closed this Sep 13, 2019
@radarhere radarhere mentioned this pull request Sep 13, 2019
@radarhere
Copy link
Member Author

Okay. See #4063 instead

@radarhere radarhere deleted the auto_transpose branch September 21, 2019 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TIFF orientation tag handled differently from most other software when loading G4 TIFF files
2 participants