Fix double free in font loading failure #3854
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The memory is freeed in font_dealloc, doing that again leads to SIGABRT.
|
Thank you for the report and the PR! The alternative PR #3912 has been merged so let's close this. The fix will be in next week's release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory is freeed in font_dealloc, doing that again leads to SIGABRT.
Fixes #3853.
Changes proposed in this pull request:
I wanted to add test for this, but the error handling futher is broken as well (the invalid font raises IOError, which is later intepreted as missing file and loader tries to do
os.path.basenameon a file like object), so I ended up fixing the crash only for now.