Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use stdlib for setuptools on Cygwin #6760

Merged
merged 1 commit into from Nov 25, 2022

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Nov 25, 2022

Alternative to #6759

pyroma 4.1 was released yesterday. It now requires setuptools >= 61. This has started Cygwin failing in main - https://github.com/python-pillow/Pillow/actions/runs/3544062653

This PR uses SETUPTOOLS_USE_DISTUTILS=stdlib, as suggested previously.

Copy link
Member

@hugovk hugovk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

The plan is that distlib will be removed from the stdlib in Python 3.12:

Python 3.12 final is due out in October 2023, with an alpha already out:

We should start testing 3.12 at some point, I think before the beta period (May 2023) would make sense, because there shouldn't be any feature changes during the beta, and if there's big problems with setuptools/distlib we may be able to give useful feedback before it's too late. (Having said that, for Cygwin we've not been testing pre-releases.)

So we may need to revisit this. But we may see more churn in setuptools before then, so I think this is fine for the time being. 👍

@hugovk hugovk merged commit ad938d5 into python-pillow:main Nov 25, 2022
@radarhere radarhere deleted the cygwin_stdlib branch November 26, 2022 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants