Fix loading FriBiDi on Alpine #6165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugovk
approved these changes
Mar 31, 2022
No, this my code written for Pillow (in #5062). I added |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing python-pillow/pillow-wheels#271, I find the tests pass, but Raqm is not enabled even when I install FriBiDi.
On Alpine, fribidi is at
/usr/lib/libfribidi.so.0, and I can see the seconddlopencall succeeds when usingstrace. However, the shim is still rejecting the SO. This is because thedlerrorcall returns the error for the firstdlopencall.This could be fixed by calling
dlerrorbefore retrying to clear the error, but since alldlsymreturn values are checked to be non-null, there is actually no need to checkdlerrorat all.See PR adding tests in python-pillow/pillow-wheels#274