Added support for PPM arbitrary maxval #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radarhere
force-pushed
the
ppm_maxval
branch
2 times, most recently
from
fefce6a
to
0cbeac6
Compare
radarhere
changed the title
hugovk
reviewed
Mar 13, 2022
Tests/test_file_ppm.py
Outdated
| assert im.get_format_mimetype() == "image/x-portable-pixmap" | ||
|
|
||
|
|
||
| def test_arbitrary_maxval(): |
There was a problem hiding this comment.
Can these mode be parametrised? Looks like one input bytestring and two things to assert.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #5008
Resolves #5403
#5008 points out that the PPM
maxvaldoes not just indicate the bit depth of an image. It is an arbitrary number, that "Must be less than 65536 and more than zero."The example from the issue has a
maxvalof 11 (not 2 ** 11, but just 11), and https://en.wikipedia.org/wiki/Netpbm#PGM_example shows an example where themaxvalis 15. So when it is 15, the values range between 0 and 15, from black to white.This PR