Replace 'setup.py sdist' with '-m build --sdist' #5785
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Direct invocation of
setup.py
has been deprecated bysetuptools
, and there's a multi-year effort ongoing to replace its commands with other tools.The long version:
Direct calling isn't going away any time soon, but we should start to replace those that we can. Here's one of the simpler replacements.
I compared the generated
Pillow-9.0.0.dev0.tar.gz
with the old and new commands, and the contents were identical (except for this change to theMakefile
).We currently use these: