Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved getxmp() #5455

Merged
merged 3 commits into from Jun 28, 2021
Merged

Improved getxmp() #5455

merged 3 commits into from Jun 28, 2021

Conversation

radarhere
Copy link
Member

@radarhere radarhere commented Apr 30, 2021

Resolves #5454 by correcting how JPEG getxmp() descends into XML
Resolves #5531 by adding getxmp() methods for PNG and TIFF

@EpicWink
Copy link

EpicWink commented Apr 30, 2021

My feature request, and by extension this PR, breaks API (it introduces intermediate dictionaries on the path). I personally think this is fine as Pillow v8.2 introduced many breaking changes to Exif reading anyway, and is fairly recent.

As I said in #5454, exiftool already produces Exif that the current API can't support, so maybe it's worth the breaking change.

@radarhere radarhere changed the title Corrected JPEG getxmp() descending into XML Improved getxmp() Jun 12, 2021
@radarhere radarhere mentioned this pull request Jun 12, 2021
@hugovk hugovk merged commit b5c4b9a into python-pillow:master Jun 28, 2021
@hugovk hugovk mentioned this pull request Jun 28, 2021
23 tasks
@radarhere radarhere deleted the xmp branch June 28, 2021 22:57
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 30, 2021
radarhere added a commit to radarhere/Pillow that referenced this pull request Jun 30, 2021
@radarhere radarhere mentioned this pull request Jun 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PNG and TIFF XMP Tag values are ignored in JPEG XMP construction
3 participants