Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Pillow 8.3.0 on July 1, 2021 #5413

Closed
23 tasks done
hugovk opened this issue Apr 17, 2021 · 10 comments
Closed
23 tasks done

Release Pillow 8.3.0 on July 1, 2021 #5413

hugovk opened this issue Apr 17, 2021 · 10 comments
Assignees
Labels
Projects
Milestone

Comments

@hugovk
Copy link
Member

hugovk commented Apr 17, 2021

Add release notes

Main Release

Released quarterly on January 2nd, April 1st, July 1st and October 15th.

  • Open a release ticket e.g. Release Pillow 5.2.0 on July 1, 2018 #3154
  • Develop and prepare release in master branch.
  • Check GitHub Actions and AppVeyor to confirm passing tests in master branch.
  • Check that all of the wheel builds Pillow Wheel Builder pass the tests in Travis CI and GitHub Actions.
  • In compliance with PEP 440, update version identifier in src/PIL/_version.py
  • Update CHANGES.rst.
  • Run pre-release check via make release-test in a freshly cloned repo.
  • Create branch and tag for release e.g.:
    git branch 8.3.x
    git tag 8.3.0
    git push --all
    git push --tags
  • Create and check source distribution:
    make sdist
    twine check dist/*
  • Create binary distributions
  • Check and upload all binaries and source distributions e.g.:
    twine check dist/*
    twine upload dist/Pillow-8.3.0*
  • Publish the release on GitHub
  • In compliance with PEP 440, increment and append .dev0 to version identifier in src/PIL/_version.py

Binary Distributions

Windows

Mac and Linux

Publicize Release

Documentation

Docker Images

  • Update Pillow in the Docker Images repository
    git clone https://github.com/python-pillow/docker-images
    cd docker-images
    ./update-pillow-tag.sh [[release tag]]
@hugovk hugovk added the Release label Apr 17, 2021
@hugovk hugovk added this to the 8.3.0 milestone Apr 17, 2021
@hugovk hugovk added this to New Issues in Pillow via automation Apr 17, 2021
@hugovk hugovk pinned this issue Apr 17, 2021
@radarhere radarhere self-assigned this Jun 23, 2021
@radarhere
Copy link
Member

Hi @cgohlke, could we have Windows binaries for 8.3.0?

@nulano
Copy link
Contributor

nulano commented Jul 1, 2021

I had to disable feature.raqm, otherwise _imagingft.pyd would depend on raqm.dll on my system.

To solve some runtime linking issues with wheels on Linux, in #5062 I proposed some changes that turned out to be difficult to compile from source with pip (because Raqm is C99, which is incompatible with GCC defaults on some systems). So these changes should only be enabled when building release wheels, which requires building with the new --global-option --vendor-raqm --global-option --vendor-fribidi flags as seen here: python-pillow/pillow-wheels#181 (comment) Those prevent _imagingft.pyd from having a dependency on raqm.dll, and it should instead link fribidi.dll at runtime.

@radarhere
Copy link
Member

Thanks @cgohlke!

Released, and announced!

@aclark4life
Copy link
Member

And pinned!

Screen Shot 2021-07-01 at 5 30 24 AM

@hugovk
Copy link
Member Author

hugovk commented Jul 5, 2021

Looks like we need an 8.3.1 patch release: #5571 is affecting lots who use NumPy either directly or indirectly (like torchvision), and there's a PR at #5572.

And separately, Windows wheels would benefit from a new dependency, so a patch release would help there: #5573 (comment)

Is there anything else urgent that warrants inclusion in 8.3.1?

@radarhere
Copy link
Member

There are some flags in #5413 (comment) that cgohlke needs to apply to releases to resolve #4859. Not urgent, but something to flag for the next release.

@wiredfool
Copy link
Member

On the bright side, I'm about 1.5 core months into a fuzzing run on a 8.3 near prerelease and nothing has come up.

@radarhere
Copy link
Member

It would be good to include fixes for #5580 and #5583

@hugovk
Copy link
Member Author

hugovk commented Jul 6, 2021

It would be good to include fixes for #5580 and #5583

Agreed, let's include those regression fixes. Thanks for the PRs, I've merged them to master.

I think we're ready to do 8.3.1? @radarhere Can you do it? If not, I can do it this evening (Europe time).

@radarhere
Copy link
Member

Sure, I can do it. Closing. Future discussion can be in #5578

Pillow automation moved this from New Issues to Closed Jul 6, 2021
@radarhere radarhere unpinned this issue Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Pillow
  
Closed
Development

No branches or pull requests

5 participants