Do not pass None to subprocess

python-pillow · Mar 14, 2022 · f3b7ee2 · f3b7ee2
1 parent 6faebd3
commit f3b7ee2
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/src/PIL/ImageShow.py b/src/PIL/ImageShow.py
@@ -270,8 +270,9 @@ def show_file(self, path=None, **options):
             else:
                 raise TypeError("Missing required argument: 'path'")
         args = ["display"]
-        if "title" in options:
-            args += ["-title", options["title"]]
+        title = options.get("title")
+        if title:
+            args += ["-title", title]
         args.append(path)
 
         subprocess.Popen(args)
@@ -368,8 +369,9 @@ def show_file(self, path=None, **options):
             else:
                 raise TypeError("Missing required argument: 'path'")
         args = ["xv"]
-        if "title" in options:
-            args += ["-name", options["title"]]
+        title = options.get("title")
+        if title:
+            args += ["-name", title]
         args.append(path)
 
         subprocess.Popen(args)