Skip to content

Commit

Permalink
Merge pull request #4371 from radarhere/coverage
Browse files Browse the repository at this point in the history
Fixed Python coverage on GitHub Actions
  • Loading branch information
hugovk committed Jan 24, 2020
2 parents 8e33285 + 6eed483 commit d33d467
Show file tree
Hide file tree
Showing 6 changed files with 22 additions and 18 deletions.
14 changes: 4 additions & 10 deletions .ci/after_success.sh
@@ -1,19 +1,13 @@
#!/bin/bash

# gather the coverage data
if [[ "$MATRIX_OS" == "macOS-latest" ]]; then
brew install lcov
pip3 install codecov
if [[ $MATRIX_DOCKER ]]; then
coverage xml --ignore-errors
else
sudo apt-get -qq install lcov
coverage xml
fi

lcov --capture --directory . -b . --output-file coverage.info
# filter to remove system headers
lcov --remove coverage.info '/usr/*' -o coverage.filtered.info

pip install codecov
coverage report

if [[ $TRAVIS ]]; then
codecov
fi
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/test-docker.yml
Expand Up @@ -41,20 +41,25 @@ jobs:
run: |
# The Pillow user in the docker container is UID 1000
sudo chown -R 1000 $GITHUB_WORKSPACE
docker run -v $GITHUB_WORKSPACE:/Pillow pythonpillow/${{ matrix.docker }}:${{ matrix.dockerTag }}
docker run --name pillow_container -v $GITHUB_WORKSPACE:/Pillow pythonpillow/${{ matrix.docker }}:${{ matrix.dockerTag }}
sudo chown -R runner $GITHUB_WORKSPACE
- name: After success
if: success()
run: |
PATH="$PATH:~/.local/bin"
docker start pillow_container
pil_path=`docker exec pillow_container /vpy3/bin/python -c 'import os, PIL;print(os.path.realpath(os.path.dirname(PIL.__file__)))'`
docker stop pillow_container
sudo mkdir -p $pil_path
sudo cp src/PIL/*.py $pil_path
.ci/after_success.sh
env:
COVERALLS_REPO_TOKEN: ${{ secrets.COVERALLS_REPO_TOKEN }}
MATRIX_DOCKER: ${{ matrix.docker }}

- name: Prepare coverage token
if: success() && github.repository == 'python-pillow/Pillow'
run: cp .github/codecov-upstream.yml .codecov.yml
run: cp .github/codecov-upstream.yml codecov.yml

- name: Upload coverage
if: success()
Expand Down
9 changes: 8 additions & 1 deletion .github/workflows/test-windows.yml
Expand Up @@ -364,15 +364,22 @@ jobs:
name: errors
path: Tests/errors

- name: After success
if: success()
run: |
.ci/after_success.sh
shell: pwsh

- name: Prepare coverage token
if: success() && github.repository == 'python-pillow/Pillow'
run: cp .github/codecov-upstream.yml .codecov.yml
run: cp .github/codecov-upstream.yml codecov.yml

- name: Upload coverage
if: success()
uses: codecov/codecov-action@v1
with:
token: ${{ secrets.CODECOV_TOKEN }}
file: ./coverage.xml
name: ${{ runner.os }} Python ${{ matrix.python-version }}

- name: Build wheel
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/test.yml
Expand Up @@ -87,12 +87,10 @@ jobs:
if: success()
run: |
.ci/after_success.sh
env:
MATRIX_OS: ${{ matrix.os }}
- name: Prepare coverage token
if: success() && github.repository == 'python-pillow/Pillow'
run: cp .github/codecov-upstream.yml .codecov.yml
run: cp .github/codecov-upstream.yml codecov.yml

- name: Upload coverage
if: success()
Expand Down
2 changes: 1 addition & 1 deletion MANIFEST.in
Expand Up @@ -18,10 +18,10 @@ graft docs
# build/src control detritus
exclude .appveyor.yml
exclude .coveragerc
exclude .codecov.yml
exclude .editorconfig
exclude .readthedocs.yml
exclude azure-pipelines.yml
exclude codecov.yml
global-exclude .git*
global-exclude *.pyc
global-exclude *.so
Expand Down
File renamed without changes.

0 comments on commit d33d467

Please sign in to comment.