Merge pull request #5363 from radarhere/unreachable

Removed build_distance_tables return value
python-pillow · Mar 27, 2021 · 9431d94 · 9431d94
2 parents 9b69d94 + a4a38b8
commit 9431d94
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/src/libImaging/Quant.c b/src/libImaging/Quant.c
@@ -789,7 +789,7 @@ resort_distance_tables(
     return 1;
 }
 
-static int
+static void
 build_distance_tables(
     uint32_t *avgDist, uint32_t **avgDistSortKey, Pixel *p, uint32_t nEntries) {
     uint32_t i, j;
@@ -811,7 +811,6 @@ build_distance_tables(
             sizeof(uint32_t *),
             _sort_ulong_ptr_keys);
     }
-    return 1;
 }
 
 static int
@@ -1373,9 +1372,7 @@ quantize(
         goto error_6;
     }
 
-    if (!build_distance_tables(avgDist, avgDistSortKey, p, nPaletteEntries)) {
-        goto error_7;
-    }
+    build_distance_tables(avgDist, avgDistSortKey, p, nPaletteEntries);
 
     if (!map_image_pixels_from_median_box(
             pixelData, nPixels, p, nPaletteEntries, h, avgDist, avgDistSortKey, qp)) {
@@ -1580,9 +1577,7 @@ quantize2(
         goto error_3;
     }
 
-    if (!build_distance_tables(avgDist, avgDistSortKey, p, nQuantPixels)) {
-        goto error_4;
-    }
+    build_distance_tables(avgDist, avgDistSortKey, p, nQuantPixels);
 
     if (!map_image_pixels(
             pixelData, nPixels, p, nQuantPixels, avgDist, avgDistSortKey, qp)) {