add explanatory comment for USE_WIN32_FILEIO

python-pillow · Mar 26, 2021 · 7c48f12 · 7c48f12
1 parent 1105c5d
commit 7c48f12
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/setup.py b/setup.py
@@ -728,6 +728,10 @@ def build_extensions(self):
             libs.append(feature.tiff)
             defs.append(("HAVE_LIBTIFF", None))
             if sys.platform == "win32":
+                # This define needs to be defined if-and-only-if it was defined
+                # when compiling LibTIFF. LibTIFF doesn't expose it in `tiffconf.h`,
+                # so we have to guess; by default it is defined in all Windows builds.
+                # See #4237, #5243, #5359 for more information.
                 defs.append(("USE_WIN32_FILEIO", None))
         if feature.xcb:
             libs.append(feature.xcb)