Merge pull request #4381 from radarhere/memory

Release buffer if function returns prematurely
python-pillow · Mar 25, 2020 · 5e4b6e9 · 5e4b6e9
2 parents 291f1eb + e7ce609
commit 5e4b6e9
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/src/map.c b/src/map.c
@@ -354,17 +354,21 @@ PyImaging_MapBuffer(PyObject* self, PyObject* args)
 
     if (view.len < 0) {
         PyErr_SetString(PyExc_ValueError, "buffer has negative size");
+        PyBuffer_Release(&view);
         return NULL;
     }
     if (offset + size > view.len) {
         PyErr_SetString(PyExc_ValueError, "buffer is not large enough");
+        PyBuffer_Release(&view);
         return NULL;
     }
 
     im = ImagingNewPrologueSubtype(
         mode, xsize, ysize, sizeof(ImagingBufferInstance));
-    if (!im)
+    if (!im) {
+        PyBuffer_Release(&view);
         return NULL;
+    }
 
     /* setup file pointers */
     if (ystep > 0)