release python GIL during WEBP encode

python-pillow · Feb 17, 2020 · 0d5e800 · 0d5e800
1 parent 8ec548d
commit 0d5e800
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/src/_webp.c b/src/_webp.c
@@ -21,6 +21,16 @@
 
 #endif
 
+void ImagingSectionEnter(ImagingSectionCookie* cookie)
+{
+    *cookie = (PyThreadState *) PyEval_SaveThread();
+}
+
+void ImagingSectionLeave(ImagingSectionCookie* cookie)
+{
+    PyEval_RestoreThread((PyThreadState*) *cookie);
+}
+
 /* -------------------------------------------------------------------- */
 /* WebP Muxer Error Handling                                            */
 /* -------------------------------------------------------------------- */
@@ -555,6 +565,7 @@ PyObject* WebPEncode_wrapper(PyObject* self, PyObject* args)
     Py_ssize_t exif_size;
     Py_ssize_t xmp_size;
     size_t ret_size;
+    ImagingSectionCookie cookie;
 
     if (!PyArg_ParseTuple(args, "y#iiifss#s#s#",
                 (char**)&rgb, &size, &width, &height, &lossless, &quality_factor, &mode,
@@ -567,23 +578,31 @@ PyObject* WebPEncode_wrapper(PyObject* self, PyObject* args)
         }
         #if WEBP_ENCODER_ABI_VERSION >= 0x0100
         if (lossless) {
+            ImagingSectionEnter(&cookie);
             ret_size = WebPEncodeLosslessRGBA(rgb, width, height, 4 * width, &output);
+            ImagingSectionLeave(&cookie);
         } else
         #endif
         {
+            ImagingSectionEnter(&cookie);
             ret_size = WebPEncodeRGBA(rgb, width, height, 4 * width, quality_factor, &output);
+            ImagingSectionLeave(&cookie);
         }
     } else if (strcmp(mode, "RGB")==0){
         if (size < width * height * 3){
             Py_RETURN_NONE;
         }
         #if WEBP_ENCODER_ABI_VERSION >= 0x0100
         if (lossless) {
+            ImagingSectionEnter(&cookie);
             ret_size = WebPEncodeLosslessRGB(rgb, width, height, 3 * width, &output);
+            ImagingSectionLeave(&cookie);
         } else
         #endif
         {
+            ImagingSectionEnter(&cookie);
             ret_size = WebPEncodeRGB(rgb, width, height, 3 * width, quality_factor, &output);
+            ImagingSectionLeave(&cookie);
         }
     } else {
         Py_RETURN_NONE;