Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore D202 where necessary #50

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Apr 25, 2020

This is required as PyCQA/pydocstyle#426 does not
fix the issue for async def'd inner functions, causing
D202: No blank lines allowed after function docstring (found 1)

The ignores can be removed when PyCQA/pydocstyle#466 gets fixed.

This is required as PyCQA/pydocstyle#426 does not
fix the issue for async def'd inner functions.
@codecov-io
Copy link

codecov-io commented Apr 25, 2020

Codecov Report

Merging #50 into master will decrease coverage by 0.48%.
The diff coverage is 62.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #50      +/-   ##
==========================================
- Coverage   70.68%   70.20%   -0.49%     
==========================================
  Files           9        9              
  Lines        1071     1094      +23     
  Branches      153      157       +4     
==========================================
+ Hits          757      768      +11     
- Misses        293      305      +12     
  Partials       21       21              
Impacted Files Coverage Δ
kasa/cli.py 51.79% <0.00%> (ø)
kasa/smartplug.py 100.00% <ø> (ø)
kasa/smartdevice.py 83.39% <53.33%> (-3.20%) ⬇️
kasa/smartstrip.py 85.13% <100.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28c1811...f9ea1a4. Read the comment docs.

@basnijholt basnijholt merged commit 51af780 into python-kasa:master Apr 25, 2020
@rytilahti rytilahti deleted the fix/fix_d202 branch April 25, 2020 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants