Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --disable-formats CLI flag for selecting formats to disable #231

Closed
sirosen opened this issue Jan 20, 2023 · 3 comments
Closed

Add --disable-formats CLI flag for selecting formats to disable #231

sirosen opened this issue Jan 20, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@sirosen
Copy link
Member

sirosen commented Jan 20, 2023

Driven by the use-case in #220, and a chance to clean up the CLI interface over time.


--disable-format and --regex-format disable overlap. And neither satisfies a user who wants to disable exactly one format (as in #220).

Proposed new usage would be:

# replaces --regex-format=disable
--disable-formats regex
# replaces --disable-format
--disable-formats ALL
# allows disabling multiple formats by parsing comma-separated list
--disable-formats uri-reference,regex,date

In the initial version, the CLI parser can handle all of these and define disabled format information for the format opts, normalizing new and old usages.
After that, I can flag the old usages deprecated for a while and eventually drop them.

EDIT: As a brief note to future readers, --disable-formats "*" was chosen instead of ALL.

@sirosen
Copy link
Member Author

sirosen commented May 4, 2023

@binste, I know you were waiting on this, and I apologize for the long delay, but I've got this work right around the corner (#261).
Hopefully it's not too late to be useful to you. I'll wait to close this until I do the release, so you'll get notified when it comes out.

@sirosen
Copy link
Member Author

sirosen commented May 4, 2023

0.23.0 is released with the new --disable-formats.

@sirosen sirosen closed this as completed May 4, 2023
@binste
Copy link

binste commented May 4, 2023

This is great, thank you very much @sirosen and no reason to apologise. I'll integrate this into the Altair test pipeline soon, it's definitely still useful!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants