Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate incoming jsonschemas from Vega-lite within tests #2801

Closed
mattijn opened this issue Jan 4, 2023 · 1 comment · Fixed by #3061
Closed

Validate incoming jsonschemas from Vega-lite within tests #2801

mattijn opened this issue Jan 4, 2023 · 1 comment · Fixed by #3061
Assignees

Comments

@mattijn
Copy link
Contributor

mattijn commented Jan 4, 2023

As was pointed out here #2771 (comment) it is recommended to validate the incoming static jsonschemas:

The schema is included within Altair so it make sense to validate the vega-lite schema during development. Then we can catch these issues before it is shipped. Maybe we can set up a test for this within Github Action.

Yes! This is the thing I usually recommend -- if you have a static schema which you think is supposed to be valid, validate it in CI, then you'll know if something's wrong, but otherwise the library proceeds as normal.

check-jsonschema could be used here, as is described in this comment: #2771 (comment)

@binste
Copy link
Contributor

binste commented May 4, 2023

check-jsonschema 0.23.0 is out now, see python-jsonschema/check-jsonschema#231 (comment). it has support for selectively disabling format checks which is what we need here. I'll work on this soon, feel free to assign to me if it's helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants