Stops ParseResult.from_string from accepting ports not preceded by a ':' character #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/rfc3986/misc.py
Outdated
| @@ -51,7 +51,7 @@ | |||
| ( | |||
| "^(?:(?P<userinfo>{})@)?" # userinfo | |||
| "(?P<host>{})" # host | |||
| ":?(?P<port>{})?$" # port | |||
| "(:(?P<port>{}))?$" # port | |||
There was a problem hiding this comment.
Should be a non-capturing group on the outside as we don't need to capture :<port> as well as <port>
There was a problem hiding this comment.
Yup, good catch. Fixed it just now.
JohnJamesUtley
force-pushed
the
fix_port_colon
branch
from
779cb47
to
c8ad43f
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102