Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(Encoded)URL round-tripping of + in query #146

Merged
merged 2 commits into from
Dec 29, 2020
Merged

(Encoded)URL round-tripping of + in query #146

merged 2 commits into from
Dec 29, 2020

Commits on Dec 28, 2020

  1. Test URL round-tripping of + in query

    @twm
    twm committed Dec 28, 2020
    Configuration menu
    Copy the full SHA
    b69be9e View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2020

  1. Don't force encode + 

    Before:

>>> URL(scheme='https', host='foo', query={'f+o o': 'b+a r'}).to_text()
'https://foo/?f%2Bo o=b%2Ba r'

After:

>>> URL(scheme='https', host='foo', query={'f+o o': 'b+a r'}).to_text()
'https://foo/?f+o o=b+a r'

If spaces pass unencoded, surely + can.
    @twm
    twm committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    a9eba07 View commit details
    Browse the repository at this point in the history