Fix repr() checks for Python 3.10 #1254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stating Python 3.10 alpha 7, repr() was modified as follow: bpo-40066: Enum: adjust repr() to show only enum and member name (not value, nor angle brackets) and str() to show only member name. Update and improve documentation to match. bpo-40066: Enum’s repr() and str() have changed: repr() is now EnumClass.MemberName and str() is MemberName. Additionally, stdlib Enum’s whose contents are available as module attributes, such as RegexFlag.IGNORECASE, have their repr() as module.name, e.g. re.IGNORECASE. See https://bugs.python.org/issue40066 This commit fixes the assertions to match the new repr() behavior. Fix python-hyper#1253
|
Thanks for sending this PR and trying to fix this new backward-incompatible change in the upcoming Python 3.10. Unfortunately - since it is backward-incompatible - we can't merge this as it would break on all older versions as well. The tests in CI already fail, so we need a smarter approach to get this right. Assuming this change to py3.10 doesn't get reverted - I see there are already quite a few complaints on the bug tracker. If they really move forward with this change, we might need to introduce such an ugly workaround as in pytest-dev/pytest#8540, but I want to "wait and see" first. |
It got reverted. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stating Python 3.10 alpha 7, repr() was modified as follow:
bpo-40066: Enum: adjust repr() to show only enum and member name
(not value, nor angle brackets) and str() to show only member name.
Update and improve documentation to match.
bpo-40066: Enum’s repr() and str() have changed: repr() is
now EnumClass.MemberName and str() is MemberName. Additionally,
stdlib Enum’s whose contents are available as module attributes,
such as RegexFlag.IGNORECASE, have their repr() as module.name,
e.g. re.IGNORECASE.
See https://bugs.python.org/issue40066
This commit fixes the assertions to match the new repr() behavior.
Fix #1253