filesize: add support for the ronna and quetta prefixes #142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #142 +/- ##
==========================================
- Coverage 99.19% 99.19% -0.01%
==========================================
Files 9 9
Lines 746 744 -2
==========================================
- Hits 740 738 -2
Misses 6 6
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Hi! I have no idea how to add a "PR label". |
|
I'll add the PR label, thanks! (And it's an addition not skip.) Please could you add some test cases so Y, YiB, and YB are still covered somehow? |
for more information, see https://pre-commit.ci
Done. |
hugovk
reviewed
Aug 19, 2023
| for i, s in enumerate(suffix): | ||
| unit = base ** (i + 2) | ||
| if abs_bytes < base: | ||
| return ("%dB" if gnu else "%d Bytes") % bytes_ |
There was a problem hiding this comment.
Let's keep the previous two if statements.
There was a problem hiding this comment.
It seems weird to do the same abs_bytes < basecompare twice...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.