Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added intsuffix #1

Closed
wants to merge 2 commits into from
Closed

Added intsuffix #1

wants to merge 2 commits into from

Conversation

ZuluPro
Copy link

@ZuluPro ZuluPro commented Mar 17, 2022

Added intsuffix to humanize into just the symbol k, M, G, P, T, etc

@hugovk
Copy link
Member

hugovk commented Apr 14, 2022

Thanks for the PR! Please also add it to __all__ in https://github.com/python-humanize/humanize/blob/master/src/humanize/__init__.py, that should fix the tests.

@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@fb06292). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main       #1   +/-   ##
=======================================
  Coverage        ?   99.69%           
=======================================
  Files           ?        9           
  Lines           ?      659           
  Branches        ?        0           
=======================================
  Hits            ?      657           
  Misses          ?        2           
  Partials        ?        0           
Flag Coverage Δ
GHA_Ubuntu 98.48% <0.00%> (?)
GHA_Windows 98.17% <0.00%> (?)
GHA_macOS 98.48% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb06292...8b809c1. Read the comment docs.

@hugovk
Copy link
Member

hugovk commented Apr 26, 2022

Thinking about the name intsuffix: what we're doing here is taking a large integer, and finding a good "unit prefix" to go with it.

Would intprefix be a better name?

@hugovk
Copy link
Member

hugovk commented Jun 19, 2022

Closing in favour of #22 which should more-or-less cover this too. Thanks!

@hugovk hugovk closed this Jun 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: Added For new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants