Remove obsolete python and compiler support #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th the removal of Python 2.7. Also requires a compiler that supports a 'noinline' directive.
…Win. We are firmly in the 'need c++11 or greater' camp now.
There was a size mismatch in our instruction and our return value. It doesn't really make any difference because we're using an immediate 0 value, but this silences the warning.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3.7 is the oldest version not past its end of life, so that's where I'm cutting things. Because this is both API and ABI binary compatible with greenlet 2.x, it won't force downstream projects to drop support unless they want to.
This removes a fair amount of legacy code; especially the removal of the
#if/#elseblocks contributes substantially to readability.