Change note for #330 #356.

python-greenlet · Jun 20, 2023 · 64fd8ce · 64fd8ce
1 parent 2e3fd61
commit 64fd8ce
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 0 deletions.
diff --git a/CHANGES.rst b/CHANGES.rst
@@ -8,6 +8,10 @@
 - Build binary wheels for S390x Linux. See `PR 358
   <https://github.com/python-greenlet/greenlet/pull/358>`_ from Steven
   Silvester.
+- Fix a rare crash on shutdown seen in uWSGI deployments. See `issue
+  330 <https://github.com/python-greenlet/greenlet/issues/330>`_ and `PR 356
+  <https://github.com/python-greenlet/greenlet/pull/356>`_ from Andrew
+  Wason.
 
 
 2.0.2 (2023-01-28)

diff --git a/src/greenlet/greenlet.cpp b/src/greenlet/greenlet.cpp
@@ -299,6 +299,12 @@ class ImmortalException : public ImmortalObject
 // established at init time.
 // This is a step towards Python3 style module state that allows
 // reloading.
+//
+// In an earlier iteration of this code, we used placement new to be
+// able to allocate this object statically still, so that references
+// to its members don't incur an extra pointer indirection.
+// But under some scenarios, that could result in crashes at
+// shutdown because apparently the destructor was getting run twice?
 class GreenletGlobals
 {
 public: