New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a decorator that stops successive duplicate invocations of commands #88
Add a decorator that stops successive duplicate invocations of commands #88
Conversation
❌ Deploy Preview for bot-core failed.
|
Co-authored-by: MarkKoz <KozlovMark@gmail.com>
f185070
to
7721047
Compare
7721047
to
c3814a2
Compare
c3814a2
to
805c604
Compare
the package now requires python 3.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I forgot about this PR. Sorry it took me so long to take notice again. Just have some small suggestions.
For the failing doc I've opened tox-dev/sphinx-autodoc-typehints#255 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm out of my depth with the sphinx changes you've made, so I'll defer reviews of that to someone more experienced.
while only iterable is strictly needed, any reader would expect the function to return a tuple
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Once sphinx-autodoc-typehints makes a release with your change we can get this updated and merged!
Ports over
update_wrapper_globals
/command_wraps
and adds a decorator that stops successive duplicate invocations of a command with the same arguments in the same channel.I've extended the source lookup func for linkcode to also look into if statements for the
if TYPE_CHECKING
use and added a guard to prevent if from erroring on cases that aren't taken care of. It's still missing on some different cases where assignments could occur but that can be addressed in a different PR specifically for thatcloses: #87