Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add place_varga in API doc #1004

Merged
merged 2 commits into from
May 18, 2024
Merged

Conversation

pierre-haessig
Copy link
Contributor

Hello,

This is a tiny PR proposal to add place_varga to the Function reference/Control system synthesis documentation page.

I guess this was forgotten in #176 when the original place was renamed place_varga. Unless it is intentional?

Also, this may fix the non working of link to place_varga in place doc (in See also section: acker link is fine, but not place_varga ).

@slivingston slivingston self-assigned this May 17, 2024
@slivingston
Copy link
Member

Thanks! Yes, this fixes the link to place_varga. While reviewing this, I noticed the place_varga docstring did not have correct "See Also" numpydoc syntax, so I changed it. (This affects link generation.)

@slivingston slivingston merged commit 6178097 into python-control:main May 18, 2024
11 of 12 checks passed
@coveralls
Copy link

Coverage Status

coverage: 94.503%. remained the same
when pulling c63712e on pierre-haessig:doc-varga
into 2d1f514 on python-control:main.

@pierre-haessig
Copy link
Contributor Author

Thanks! I had some further ideas that I started in #1006.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants