Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefer setuptools imports to distutils imports #843

Merged
merged 1 commit into from Apr 8, 2022
Merged

Conversation

akx
Copy link
Member

@akx akx commented Feb 23, 2022

Considering distutils is being deprecated, this fixes up things so imports from setuptools are used where available instead.

The non-conditional imports have been around for 6 to 17 years, so they should be safe in conservative situations too.

Refs #824

The non-conditional imports have been around for 6 to 17 years,
so they should be safe in conservative situations too.

Refs #824
@codecov
Copy link

codecov bot commented Feb 23, 2022

Codecov Report

Merging #843 (4f4ab10) into master (9033f02) will decrease coverage by 0.13%.
The diff coverage is 47.50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
- Coverage   91.16%   91.02%   -0.14%     
==========================================
  Files          23       23              
  Lines        4152     4158       +6     
==========================================
  Hits         3785     3785              
- Misses        367      373       +6     
Impacted Files Coverage Δ
babel/messages/plurals.py 100.00% <ø> (ø)
babel/messages/frontend.py 86.10% <43.24%> (-0.94%) ⬇️
babel/messages/catalog.py 95.29% <100.00%> (-0.04%) ⬇️
babel/support.py 83.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f8c7f6...4f4ab10. Read the comment docs.

@akx akx added this to the Babel 2.10 milestone Feb 23, 2022
@akx
Copy link
Member Author

akx commented Feb 24, 2022

For people working around e.g. Fedora packaging (@FelixSchwarz, @kloczek?), do you foresee this change causing trouble?

@FelixSchwarz
Copy link
Contributor

Fedora has setuptools available so I don't think this will be an issue. In general Fedora seems to be pretty much at the (b)leading edge of Python versioning so if something is deprecated upstream, chances are pretty good that Fedora's Python packaging (in general) was already adapted to support the new approach.

@akx akx merged commit 5aa000e into master Apr 8, 2022
@akx akx deleted the prefer-setuptools branch April 8, 2022 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants